Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom UOM reference for literal IO #523

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

davidcaron
Copy link
Contributor

Overview

Currently, the only UOMs allowed when serializing an input are degree, meter and unity (see pywps.OGCUNIT). With the new 'watchdog' process, the inputs are always serialized, so these units are the only ones allowed.

I think that leaving the responsibility to the PYWPS service implementation to provide the UOM reference could be a simple solution to this.

Contribution Agreement

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 74.26% when pulling d11ce24 on davidcaron:allow-custom-uom-reference into 7126011 on geopython:master.

@cehbrecht cehbrecht self-requested a review February 25, 2020 09:44
@cehbrecht
Copy link
Collaborator

@jachym This PR just extends the current UOMs implementation. We could add more common UOMs to the OGCUNIT list:

OGCUNIT = {

@cehbrecht cehbrecht merged commit 61e03fe into geopython:master Feb 25, 2020
@cehbrecht
Copy link
Collaborator

@davidcaron merged. Thanks for this contribution :)

@davidcaron davidcaron deleted the allow-custom-uom-reference branch March 17, 2020 14:53
@cehbrecht cehbrecht mentioned this pull request Feb 8, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants