Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element ref wasn't working on ng-for wizard.component.html with multiple fields #996

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

f-necas
Copy link
Collaborator

@f-necas f-necas commented Sep 20, 2024

Description

This PR introduces a fix where fields weren't all verified because the ElementRef was checked only on the first element of the list.

On second step, we could hit "Next" button even if abstract wasn't filled.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If bugs 🐞 are fixed: add the backport <release branch> label

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Affected libs: feature-editor,
Affected apps: metadata-editor, datafeeder, demo,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Sep 20, 2024

📷 Screenshots are here!

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks! Could you please address the failing CI before merging?

@coveralls
Copy link

Coverage Status

coverage: 82.189%. remained the same
when pulling 0498c36 on fix-wizard-element-ref
into 66a3379 on main.

@f-necas f-necas merged commit e5f8e61 into main Sep 22, 2024
13 checks passed
@f-necas f-necas deleted the fix-wizard-element-ref branch September 22, 2024 06:59
f-necas added a commit to georchestra/geonetwork-ui that referenced this pull request Sep 27, 2024
Element ref wasn't working on ng-for wizard.component.html with multiple fields
f-necas added a commit to georchestra/geonetwork-ui that referenced this pull request Sep 27, 2024
Element ref wasn't working on ng-for wizard.component.html with multiple fields
f-necas added a commit to georchestra/geonetwork-ui that referenced this pull request Sep 27, 2024
Element ref wasn't working on ng-for wizard.component.html with multiple fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants