-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element ref wasn't working on ng-for wizard.component.html with multiple fields #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected libs:
|
📷 Screenshots are here! |
jahow
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks! Could you please address the failing CI before merging?
f-necas
force-pushed
the
fix-wizard-element-ref
branch
from
September 22, 2024 06:39
fef1a17
to
0498c36
Compare
f-necas
added a commit
to georchestra/geonetwork-ui
that referenced
this pull request
Sep 27, 2024
Element ref wasn't working on ng-for wizard.component.html with multiple fields
f-necas
added a commit
to georchestra/geonetwork-ui
that referenced
this pull request
Sep 27, 2024
Element ref wasn't working on ng-for wizard.component.html with multiple fields
f-necas
added a commit
to georchestra/geonetwork-ui
that referenced
this pull request
Sep 27, 2024
Element ref wasn't working on ng-for wizard.component.html with multiple fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a fix where fields weren't all verified because the ElementRef was checked only on the first element of the list.
On second step, we could hit "Next" button even if abstract wasn't filled.
Quality Assurance Checklist
backport <release branch>
label