Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(platform-service): Exclude place thesarus keywords #915

Merged
merged 3 commits into from
Jun 27, 2024
Merged

fix(platform-service): Exclude place thesarus keywords #915

merged 3 commits into from
Jun 27, 2024

Conversation

Angi-Kinas
Copy link
Collaborator

Description

This PR introduces changes to the #searchKeywords function in order to get all keywords except the ones of type place.

@Angi-Kinas Angi-Kinas changed the title fix(ME): Exclude place thesarus keywords fix(platform-service): Exclude place thesarus keywords Jun 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024 •
edited
Loading

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-editor, feature-search, feature-map, feature-dataviz, feature-auth, common-domain, api-metadata-converter, ui-search, common-fixtures, ui-elements, feature-notifications, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz,
Affected apps: datahub, metadata-editor, demo, webcomponents, map-viewer, search, datafeeder, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024 •
edited
Loading

📷 Screenshots are here!

@coveralls
Copy link

Coverage Status

coverage: 85.186% (+1.8%) from 83.381%
when pulling c135460 on ME-exclude-place-thesauri-keywords
into 27089d8 on main.

@Angi-Kinas
feat(platform-service): Add argument keywordTypes
f098c15 
to searchKeywords method in order to be able to
specify the thesauri to be searched within.
Add translations for keywords label, update
translations.
@coveralls
Copy link

Coverage Status

coverage: 83.168% (-0.2%) from 83.381%
when pulling f098c15 on ME-exclude-place-thesauri-keywords
into 27089d8 on main.

jahow
jahow approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thanks!! It looks like the i18n task wasn't run for a while, I hope it's not going to break anything...

@coveralls
Copy link

Coverage Status

coverage: 83.109% (-0.3%) from 83.381%
when pulling a824251 on ME-exclude-place-thesauri-keywords
into 27089d8 on main.

@Angi-Kinas Angi-Kinas merged commit fe59f17 into main Jun 27, 2024
9 checks passed
@Angi-Kinas Angi-Kinas deleted the ME-exclude-place-thesauri-keywords branch June 27, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Angi-Kinas @coveralls @jahow