Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Feedback] : allow any auth user to answer & handle errors #885

Merged
merged 3 commits into from
May 28, 2024

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented May 24, 2024

Description

This PR allows any authenticated user to answer to comments. It also adds better handling of potential errors.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by IGN.

Copy link
Contributor

github-actions bot commented May 24, 2024

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth, ui-elements, feature-notifications, feature-editor, ui-catalog, ui-search,
Affected apps: datahub, metadata-editor, demo, webcomponents, map-viewer, search, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@cmoinier cmoinier changed the title [User Feedback] : allow any auth user to answer [User Feedback] : allow any auth user to answer & handle errors May 24, 2024
Copy link
Contributor

github-actions bot commented May 24, 2024

📷 Screenshots are here!

@fvanderbiest
Copy link
Contributor

Would you provide us with better screenshots than those provided by the bot (which are already impressive, but lack details about the comment system) ? Thx

@cmoinier
Copy link
Collaborator Author

@fvanderbiest This PR doesn't implement the comment system, but improves it a bit. However, here is what it looks like :

--> Anonymous user :

image

--> Logged-in user (any):

image

@coveralls
Copy link

Coverage Status

coverage: 85.03% (+0.7%) from 84.372%
when pulling 9a5b125 on allow-users-answer-feedback
into 2b3239d on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@cmoinier cmoinier merged commit ff2a9db into main May 28, 2024
9 checks passed
@cmoinier cmoinier deleted the allow-users-answer-feedback branch May 28, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants