Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): fix carousel buttons not showing up on Firefox #880

Merged
merged 1 commit into from
May 22, 2024

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented May 22, 2024

The buttons are positioned absolutely and the component host is positioned relatively; without a "display: block" setting as well, the buttons were simply not showing up on Firefox.

image

Conclusion: do not position relatively something that isn't a block.

Apparently putting "position: relative" on something that is not a block is
a bad idea (c)
Copy link
Contributor

Affected libs: ui-layout, feature-catalog, feature-record, feature-router, feature-dataviz, feature-editor, feature-search, feature-map, ui-elements, feature-notifications, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 84.424% (+0.6%) from 83.874%
when pulling a1996dc on fix-carousel-buttons
into 22f4da7 on main.

Copy link
Contributor

📷 Screenshots are here!

@jahow jahow merged commit 9f0464a into main May 22, 2024
9 checks passed
@jahow jahow deleted the fix-carousel-buttons branch May 22, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants