-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata Editor: Use gnUiEditableLabel directive for title input #853
Conversation
Affected libs:
|
this.titleInput.nativeElement.children[0].focus() | ||
} | ||
|
||
handleTitleChange(field: EditorFieldState, newTitle: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LHBruneton-C2C when I was writing a test for this function I realized that this function does the same as handleFieldValueChange
. EditorFieldValue
can also be a string. So I think we can use handleFieldValueChange
as well for the title. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's working this way, sure! Sharing the logic is the way to go. Can't remember why this didn't seem to work at first :/
acd7ac5
to
a243102
Compare
a243102
to
dd322b5
Compare
📷 Screenshots are here! |
Description
This PR uses the gnUiEditableLabel directive for the title input.
Screenshots
Todo
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label