Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata Editor: Use gnUiEditableLabel directive for title input #853

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

Angi-Kinas
Copy link
Collaborator

@Angi-Kinas Angi-Kinas commented Apr 11, 2024

Description

This PR uses the gnUiEditableLabel directive for the title input.

Screenshots

image

Todo

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Affected libs: feature-editor, ui-layout, feature-dataviz, feature-record, feature-router, feature-catalog, feature-search, feature-map, ui-elements, feature-notifications, ui-catalog, ui-search,
Affected apps: metadata-editor, datafeeder, demo, datahub, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

this.titleInput.nativeElement.children[0].focus()
}

handleTitleChange(field: EditorFieldState, newTitle: string) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LHBruneton-C2C when I was writing a test for this function I realized that this function does the same as handleFieldValueChange. EditorFieldValue can also be a string. So I think we can use handleFieldValueChange as well for the title. WDYT?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's working this way, sure! Sharing the logic is the way to go. Can't remember why this didn't seem to work at first :/

@coveralls
Copy link

coveralls commented Apr 18, 2024

Coverage Status

coverage: 85.163% (+1.4%) from 83.789%
when pulling dd322b5 on editor-record-field-title
into 6083baa on main.

Copy link
Contributor

📷 Screenshots are here!

@LHBruneton-C2C LHBruneton-C2C merged commit c22cb78 into main Apr 19, 2024
9 checks passed
@LHBruneton-C2C LHBruneton-C2C deleted the editor-record-field-title branch April 19, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants