Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Map-Viewer] Add layer from OGC API service #848

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Conversation

ronitjadhav
Copy link
Collaborator

@ronitjadhav ronitjadhav commented Apr 9, 2024

Description

This pull request adds the feature that allows users to add a layer from an OGC API Service to their map.

Currently, it only supports adding features!!

Following changes were made:

  • Added a new add-layer-from-ogc-api component in src/app/components/add-layer-from-ogc-api/add-layer-from-ogc-api.component.ts
  • Updated the map-context.service.ts and map-context.model.ts to add MapContextLayerOgcapiModel
  • Updated unit tests to make them pass

Screenshots

image

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

#756

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Affected libs: feature-map, feature-dataviz, feature-record, feature-router, util-data-fetcher, api-metadata-converter, api-repository, feature-catalog, feature-search, feature-auth, feature-editor, ui-search, data-access-datafeeder, util-app-config, data-access-gn4, common-fixtures, util-shared, ui-elements, ui-catalog, ui-widgets, ui-inputs, ui-layout, ui-map, common-domain, ui-dataviz, util-i18n,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Apr 9, 2024

📷 Screenshots are here!

@ronitjadhav ronitjadhav force-pushed the mv-add-from-ogc-api branch 5 times, most recently from 9d89100 to 2311498 Compare April 10, 2024 11:08
@coveralls
Copy link

coveralls commented Apr 10, 2024

Coverage Status

coverage: 84.542% (+0.5%) from 84.03%
when pulling a3e1040 on mv-add-from-ogc-api
into 376e0e9 on main.

@ronitjadhav ronitjadhav requested a review from jahow April 10, 2024 14:21
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I'll try to see if I can fix the issue with ogc-client provoking errors in the data-fetcher tests and then we can merge :) Thank you!

@Component({
selector: 'gn-ui-add-layer-from-ogc-api',
templateUrl: './add-layer-from-ogc-api.component.html',
styleUrls: ['./add-layer-from-ogc-api.component.css'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we could make this a standalone component? that would push things towards the right direction :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done !!

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't have the tests work without the ogc-client mocks, there's something going on with ts-jest but I just can't find it. So I think this can be merged :) thanks!

@ronitjadhav ronitjadhav merged commit 6e2b8be into main Apr 16, 2024
9 checks passed
@ronitjadhav ronitjadhav deleted the mv-add-from-ogc-api branch April 16, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants