-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Map-Viewer] Add layer from OGC API service #848
Conversation
Affected libs:
|
📷 Screenshots are here! |
9d89100
to
2311498
Compare
2311498
to
6b13d4a
Compare
2073d76
to
8baab12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! I'll try to see if I can fix the issue with ogc-client provoking errors in the data-fetcher tests and then we can merge :) Thank you!
@Component({ | ||
selector: 'gn-ui-add-layer-from-ogc-api', | ||
templateUrl: './add-layer-from-ogc-api.component.html', | ||
styleUrls: ['./add-layer-from-ogc-api.component.css'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we could make this a standalone component? that would push things towards the right direction :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done !!
9fab5cc
to
22f62e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't have the tests work without the ogc-client mocks, there's something going on with ts-jest but I just can't find it. So I think this can be merged :) thanks!
Description
This pull request adds the feature that allows users to add a layer from an OGC API Service to their map.
Currently, it only supports adding features!!
Following changes were made:
add-layer-from-ogc-api
component insrc/app/components/add-layer-from-ogc-api/add-layer-from-ogc-api.component.ts
map-context.service.ts
andmap-context.model.ts
to addMapContextLayerOgcapiModel
Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label#756