Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update declared dependencies of NPM package #760

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Jan 11, 2024

Follow-up of #758

  • Update OL and add a few missing dependencies according to the root package.json
  • Remove nguniversal from peer dependencies as we don't do SSR in custom apps
  • List new non-peer deps as allowed in ng-package.json

Also remove nguniversal from peer dependencies as we don't do SSR in custom
apps, and list new non-peer deps as allowed in ng-package.json
Copy link
Contributor

Affected libs: , Affected apps: ,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean exactly ?
We need to maintain those version manually ?
What happens if the versions are not the same ?

@jahow
Copy link
Collaborator Author

jahow commented Jan 11, 2024

yes currently it's a manual process; the dependencies in package/package.json will be the ones installed in the custom application when doing npm install, so if they're out of date then gn-ui features might not work correctly.

@fgravin fgravin merged commit 438f1ef into main Jan 11, 2024
7 checks passed
@fgravin fgravin deleted the package-update-deps branch January 11, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants