-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Adjust linkify directive #739
Conversation
Affected libs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice improvement, thanks @Angi-Kinas ! The only thing I see, is that the link color in the abstract should likely also be primary, shouldn't it? Maybe we could also add a test for some HTML input with an existing anchor element.
Really what we're missing is a presentation component for links. We have been copy-pasting tailwind style for these many times now, and this should be factorized in a component. |
Shouldn't this be the central place where the style should be defined? The only reason why it's displayed differently in the abstract, is because the style is overwritten here, I think. Maybe I'm missing your point for the need of a component though. Do you propose to use the UI component within the directive? |
Hmm, I think it'd be good to have a common style for all links in the app, not just the ones created by the linkify directive. But it's also true that it might not necessary be a presentation component, it could simply be a tailwind class, otherwise it'll be hard to generate it on the fly in the linkify directive. |
to be able to process HTML elements and Text. Will be used additionally in the abstract and landing page.
8879f69
to
e4bb3c2
Compare
I've reworked this PR and now the tests should be passing :) great work @Angi-Kinas, it was only a minor detail (see the template of component used in the unit test). |
Adjust linkify directive to be able to process HTML elements and Text.
Will be used additionally in the abstract and landing page.
Replaces this PR #588
/dataset/a8b5e6c0-c21d-4c32-b8f9-10830215890a (landing page link):
/dataset/n_tri_lill_inondable_s_059 (link in abstract with
<strong>
-tag):/dataset/ee965118-2416-4d48-b07e-bbc696f002c2 (multiple links in abstract):