Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web component: provide gn4 platform service #705

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Web component: provide gn4 platform service #705

merged 1 commit into from
Nov 28, 2023

Conversation

fgravin
Copy link
Member

@fgravin fgravin commented Nov 28, 2023

Injection issues in web component demos

@fgravin fgravin added the bug Something isn't working label Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

Affected libs: ``,
Affected apps: webcomponents,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 100.0% (+17.2%) from 82.809%
when pulling c1620fe on fix-wc
into e7e9323 on main.

@fgravin fgravin merged commit f0a1614 into main Nov 28, 2023
8 checks passed
@fgravin fgravin deleted the fix-wc branch November 28, 2023 16:19
@jahow
Copy link
Collaborator

jahow commented Nov 29, 2023

We need E2E tests for these so much 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgravin @coveralls @jahow