Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve autocomplete input rendering #644

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Improve autocomplete input rendering #644

merged 1 commit into from
Oct 6, 2023

Conversation

fgravin
Copy link
Member

@fgravin fgravin commented Oct 6, 2023

  • Set an input padding-right so the input text does not go under the absolute buttons.
    image

  • Add ellipsis on placeholder, works on page load but disappear on focus on Chrome
    image

@fgravin fgravin added this to the 2.0.0 milestone Oct 6, 2023
@fgravin fgravin requested a review from jahow October 6, 2023 08:22
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Affected libs: ui-inputs, feature-dataviz, feature-record, feature-router, feature-editor, feature-search, feature-map, ui-elements, feature-catalog, ui-catalog, ui-search,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 81.666% (-4.2%) from 85.915% when pulling e7ba117 on mobile-placeholder into df6fb76 on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@jahow jahow merged commit e5584f9 into main Oct 6, 2023
7 checks passed
@jahow jahow deleted the mobile-placeholder branch October 6, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants