Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datahub: Fix filter clicks close to header #643

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Datahub: Fix filter clicks close to header #643

merged 1 commit into from
Oct 5, 2023

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Oct 4, 2023

PR fixes click events close under the header (like on the filter dropdowns), by making the collapsed header around the search unclickable.

header_filter

@tkohr
fix(header): make header around search unclickable when collapsed
18e3f00 
this fixes click events close under the header (like the filter), to where some invisible element paddings overlap
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Affected libs: ``,
Affected apps: datahub,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

f-necas
f-necas approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@f-necas f-necas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly as expected ! Thanks @tkohr for this nice and clean solution :)

@tkohr tkohr merged commit df6fb76 into main Oct 5, 2023
7 checks passed
@tkohr tkohr deleted the header-fix-filter-click branch October 5, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-necas f-necas f-necas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkohr @f-necas