Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: Display link URL as fallback #633

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Datahub: Display link URL as fallback #633

merged 1 commit into from
Sep 22, 2023

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Sep 22, 2023

Add a fallback to link card for link name/description

link_url

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Sep 22, 2023

Coverage Status

coverage: 86.219% (+0.3%) from 85.915% when pulling a2face9 on link-card-url into 6733dec on main.

Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a metadata ?
I would rather put the link in the description instead of the name, it's very big here.

@tkohr
Copy link
Collaborator Author

tkohr commented Sep 22, 2023

Ok, I'll have a look if that looks better. Here's the md I'm testing with: https://geocat-dev.dev.bgdi.ch/datahub/dataset/29eea035-3995-4a39-90d7-8ae8feb26f6b

@tkohr
Copy link
Collaborator Author

tkohr commented Sep 22, 2023

Looks better indeed :-)

link_url_descr

@tkohr tkohr changed the title Datahub: Display link URL if no link name present Datahub: Display link URL as fallback Sep 22, 2023
@tkohr tkohr merged commit 1083b93 into main Sep 22, 2023
5 checks passed
@tkohr tkohr deleted the link-card-url branch September 22, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants