Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ME]: Error when trying to import a record from Geocat.ch #1010

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

rcaplier
Copy link
Collaborator

This PR introduces fix the encoding of special entities in text that caused issue when converting XML file to string (which is used when converting record to draft). And also fixed how the draft count if calculated.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by.

@rcaplier rcaplier self-assigned this Sep 30, 2024
@rcaplier rcaplier requested a review from jahow September 30, 2024 13:22
Copy link
Contributor

github-actions bot commented Sep 30, 2024

Affected libs: api-metadata-converter, feature-search, feature-router, feature-map, feature-dataviz, feature-record, api-repository, feature-catalog, feature-editor, feature-auth, ui-search, common-domain, common-fixtures, ui-elements, feature-notifications, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz,
Affected apps: metadata-editor, metadata-converter, datahub, demo, webcomponents, map-viewer, search, datafeeder, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Sep 30, 2024

📷 Screenshots are here!

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The code looks good and the issue is fixed. I modified the test for xmlToString to also test for encoding in attributes. There are a few other tests failing, can you try and fix them? Once the PR is green it can be merged.

… the way draft count badge fetch the count.
@rcaplier rcaplier force-pushed the me-fix-xml-utils-entities-encoding branch from 80ede26 to 9a84ddd Compare September 30, 2024 15:17
@coveralls
Copy link

coveralls commented Sep 30, 2024

Coverage Status

coverage: 83.108% (+2.1%) from 81.027%
when pulling bd40e8b on me-fix-xml-utils-entities-encoding
into fdf8f64 on main.

@jahow jahow merged commit e550c0b into main Sep 30, 2024
13 checks passed
@jahow jahow deleted the me-fix-xml-utils-entities-encoding branch September 30, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants