Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted changes to fix warnings & remove dead code #2

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Conversation

grjte
Copy link
Collaborator

@grjte grjte commented Jul 15, 2024

This PR does some minor tidying up:

  • The div_ceil refactor (commit 8f819a0) removes the necessity of declaring the unstable int_roundings feature in order for this repo to used externally. See Tracking Issue for int_roundings rust-lang/rust#88581
  • all other commits remove dead code and unused or broken tests, or resolve clippy warnings. In the case of imports, I updated them to follow a consistent pattern throughout the repo.

The commits are very granular to make it very easy to review/update if there's anything you want to do differently (e.g. maybe you prefer to ignore needless_range_loop clippy warnings). Happy to squash before merge if you prefer

@grjte grjte requested a review from therealyingtong July 15, 2024 16:26
Copy link
Collaborator

@therealyingtong therealyingtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grjte grjte merged commit afcb551 into main Jul 17, 2024
@grjte grjte deleted the grjte/clippy branch July 17, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants