一部のレコードで「市区町村名ローマ字」フィールドが途切れている問題を修正 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
champierre
force-pushed
the
issue_118_2
branch
5 times, most recently
from
9fbef56 to
844f06a
Compare
champierre
force-pushed
the
issue_118_2
branch
from
9d0a601 to
f55b6dd
Compare
kamataryo
reviewed
Oct 3, 2022
kamataryo
approved these changes
Oct 3, 2022
|
@champierre コンフリクトの解消だけお願いします 🙇 |
|
あ、 |
はい、そのとおりです。 |
issue-118.json は必要で、issue-118.csv が不要なので削除します。 |
|
latest.csv から抜き出してきた csv を patch 用の json 形式に変換するために使用した csv-to-json.js は gist に移したので、削除します。 https://gist.github.com/champierre/ddf80c3079eeade45a9b0f00f2ede75b |
champierre
force-pushed
the
issue_118_2
branch
from
f55b6dd to
8ca90c6
Compare
kamataryo
approved these changes
Oct 4, 2022
|
ありがとうございます、マージします！ |
champierre
changed the title
|
Closes #118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIの更新もコミットしてしまったため、内容が巨大になってしまっていますが、メインの変更は、patches 以下の変更を入れ込む処理を bin/build-api.js から bin/build.js に移動し、api だけでなく latest.csv および latest.db にも反映させたことです。