Adopt minimal Sencha Cmd package requirements #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your continued work on this @bentrm. /cc @KaiVolland I'd value your opinion on this very much (he is the expert for the |
|
From the diff I'd say this looks great! Let's wait for @KaiVolland's approval |
|
Looks good to me. |
|
Cool. Thanks to both of you @bentrm & @KaiVolland |
marcjansen
added a commit
that referenced
this pull request
Apr 16, 2015
Adopt minimal Sencha Cmd package requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to be less intrusive than #302 while still adding support for Sencha CMD. It only adds one configuration file and some docs (which may be extended in the future).
To play nice with Cmd the following changes had to be made to the newly added package.json:
-devsuffixtypeneeds to be set to codecompatVersionwill probably be helpful with upgrading to future versionsI tried it with an existing application (ExtJS 4.2.1) as well as with a newly generated test app (ExtJS 5.1).