Add missing @requires or @include statements #256
Conversation
|
The failed CI is due to openlayers.org being down. |
|
Hey Bart. Do we actually still need this? It doesn't hurt, I know, but is anyone actually building the old way? Also what is the difference between |
|
@marcjansen yeah I was working on getting things to work in build kit (old school debug loader), hence this PR. Maybe I should re-assess though if this still makes sense. If not, I'll change the PR to remove all of these annotations.
|
|
@marcjansen is it easy to change the Travis build to not depend on the hosted OL? |
|
Don't change it, as I said, this doesn't hurt and I am not opposed to this change. The CI simply runs the testsuite files... if we do not want to depend on openlayers.org, all test HTML-files need to be changed to use a local version of OpenLayers. I wouldn't call that hard, but it's a lot of work obviously. Will you possibly do this? |
|
to be honest, I haven't even been able to get things to work in a buildkit environment, and I'm about to give up on the thought and switch to using Ext.Loader |
|
You decide then. |
|
Yep, will decide soon depending on whether or not I guess the old school system to work ... |
|
this probably duplicated some of the effort of #178 |
|
okay I'm giving up on this, I have been unable to get the debug loader based on this to work, I can't seem to persuade Ext Loader that these classes have been loaded already see also: though it probably might still work for static builds (given the info in #178) What's your advice @marcjansen simply remove all these annotations and say we support Ext.Loader only? |
|
I'm going to close this one and will open up a new one when done. |
No description provided.