Add an optional keepRaw property #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the reader instance for use by the application
|
This is good to go IMHO. It does not change the default and adds an additional functionality; so no need to be over cautious here. Thanks Bart, please commit. |
bartvde
pushed a commit
that referenced
this pull request
Mar 24, 2014
Add an optional keepRaw property (r=@marcjansen)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which stores the raw parsed result on the reader instance for use by the application. A lot of times an application needs more than what can be expressed in the records of a store. This property allows an application to access the raw parser result from the OpenLayers format.
See also https://github.com/boundlessgeo/gxp/blob/master/src/script/plugins/WMSSource.js#L24:L55 for a bit of background.
TIA for any review. Tests are included.