-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GeoExt.tree.Panel and ensure drag & drop functionality by enhancing LayersTree-store #96
Conversation
6d2aa84
to
818448b
Compare
83fe3bd
to
f033492
Compare
@@ -224,34 +339,38 @@ Ext.define('GeoExt.data.store.LayersTree', { | |||
* | |||
* @private | |||
*/ | |||
onLayerCollectionChanged: function(){ | |||
onLayerCollectionChangedAdd: function(evt){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer "onLayerCollectionAdd" and ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will rename, sure!
f033492
to
a35546a
Compare
@KaiVolland as you suggested, methods are now renamed as you suggested |
It fixes the issue. I also checked with the "length" of the layers. How many can you have. I earlier described it would overwrite and not show all layers after a give numbers of layers in the legend. |
@AndersVittrup, cool thanks for the feedback |
a35546a
to
bc8254c
Compare
All seems fine to me. Please merge. 👯 |
Thanks for the reviews and tests @KaiVolland & @AndersVittrup! Again a hat-tip to the input of @weskamm |
Remove GeoExt.tree.Panel and ensure drag & drop functionality by enhancing LayersTree-store
This PR suggests a larger refactoring of the tree classes. In particular the following is suggested:
GeoExt.tree.Panel
and instead enhance theGeoExt.data.store.LayersTree
to handle any possible drag/drop eventsGeoExt.tree.Panel
to a dedicated utility classshowLayerGroupNode
config fromGeoExt.data.store.LayersTree
Additionally a bug is fixed: (we could not actually handle the store remove event before 36b8a81)
If you have been using the
GeoExt.tree.panel
previously, you now need to refactor your code fromto
Fixes #91
Please review. /cc @KaiVolland, @chrismayer & @AndersVittrup
The work in this PR has been done by @weskamm and me.