Strip last of geodesicsolutions.com

[vicos59]

All files were identified in #120.

The only 2 remaining files after these are fixed in #148

After that is merged, we should be able to close #120

[jonyo]

Also just to double check, did you do a test run through the setup/ after the changes to test to make sure it works? Well if you did, be sure to do it again after any additional changes 😄

Speaking from old experience here, one time I made what seemed like a minor adjustment and neglected to test the setup, it had some problem and it broke... 😰 Though these days with the IDE pointing out syntax errors better, that is less likely, it's still a good practice to make sure any changes get actually "run" at least once before merging to main. (and sorry if I'm preaching to the choir here lol, I know you've done a ton of testing in other areas, just wanted to verify)

[jonyo]

Instead of paypal@geodesicsolutions.org, lets make it something that is clear it would never work - paypal@example.com.

example.com is a good one for documentation and the like, it is a reserved domain specifically for use in documentation and the like. And it could never be used for a real paypal address since you need to verify your email when signing up with paypal.

[vicos59]

did you do a test run through the setup/

Other than installing site from scratch, is there a better way to test it? Are you mainly concerned that the SQL executes w/o error? If so, I could just source the sql file on the database.

[jonyo]

Same here, if the URL default serves no real purpose, use example.com. So in this case since it is for the default admin email, use admin@example.com.

[vicos59]

I seem to recall that there are also phony links in there that should also use example.com

www.MyListingsSite.com

[jonyo]

Of course whatever you change it to remember to update this spot to match.

[vicos59]

I tested using mariaDB on my PC. First I ran 1_structure.sql to create the structure, then data_misc.sql to test our data change.

The SQL batch failed with an unrelated error. Coincidentally, it did fail with one of the records that was changed.

--
-- Dumping data for table geodesic_userdata

INSERT INTO `geodesic_userdata` (`id`, `username`, `email`, `email2`, `newsletter`, `level`, `company_name`, `business_type`, `firstname`, `lastname`, `address`, `address_2`, `zip`, `city`, `state`, `country`, `phone`, `phone2`, `fax`, `url`, `date_joined`, `communication_type`, `feedback_score`, `feedback_count`, `feedback_positive_count`, `rate_sum`, `rate_num`, `optional_field_1`, `optional_field_2`, `optional_field_3`, `optional_field_4`, `optional_field_5`, `optional_field_6`, `optional_field_7`, `optional_field_8`, `optional_field_9`, `optional_field_10`, `affiliate_html`, `filter_id`, `expose_email`, `expose_company_name`, `expose_firstname`, `expose_lastname`, `expose_address`, `expose_city`, `expose_state`, `expose_country`, `expose_zip`, `expose_phone`, `expose_phone2`, `expose_fax`, `expose_url`, `expose_optional_1`, `expose_optional_2`, `expose_optional_3`, `expose_optional_4`, `expose_optional_5`, `expose_optional_6`, `expose_optional_7`, `expose_optional_8`, `expose_optional_9`, `expose_optional_10`, `account_balance`, `date_balance_negative`, `balance_freeze`, `feedback_icon`, `storefront_header`, `storefront_template_id`, `storefront_welcome_message`, `storefront_on_hold`, `storefront_home_link`, `storefront_traffic_processed_at`, `last_login_time`, `last_login_ip`, `verified`, `storefront_trials_used`) VALUES

(1, 'admin', 'admin@example.com', '', 0, 1, 'Geodesic Solutions', 0, 'admin', 'admin', 'address', '', 'zipcode', 'city', 'state', 'country', 'phone', '', 'fax', '', 0, 3, 0, 0, 0, 0, 0, '', '', '', '', '', '', '', '', '', '', '', 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0.0000, 0, 0, '', '', 0, '', 1, '', 1164053097, '2006-11-21 17:53:07', '192.168.1.124', 'no', '');

/* SQL Error (1364): Field 'attached_user_message' doesn't have a default value */

This happens because mariaDB Strict mode is enabled, as it is by default with all recent mariaDB versions (7.2+ ??).

The SQL script is not explicitly inserting data for attached_user_message and there is no default specified in the table def:

`attached_user_message` text NOT NULL,
`admin_note` text DEFAULT NULL,

This should have failed when I installed it on my test domain since my mariaDB has STRICT mode enabled. I see the admin record was inserted to the table. Hmmm, maybe the setup script disables strict mode? Confused.

If this requires a table alter, I'll leave that to you. I see a few PHP files that do inserts into that table. Not sure if they would be impacted.

Scripts that do INSERTS into geodesic_userdata

1. Anonymouse Listings
2. Bridges
3. import.classes.php function _readyDatabaseForGroup()
4. There has to be a place where new users are inserted??

I'm not really even sure what is the purpose of that column.