fix updating causing the ui to lag out like hell

geode-sdk · Nov 16, 2024 · c94a533 · c94a533
1 parent b9fb2f6
commit c94a533
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/loader/src/server/DownloadManager.cpp b/loader/src/server/DownloadManager.cpp
@@ -28,6 +28,7 @@ class ModDownload::Impl final {
     DownloadStatus m_status;
     EventListener<ServerRequest<ServerModVersion>> m_infoListener;
     EventListener<web::WebTask> m_downloadListener;
+    unsigned int m_scheduledEventForFrame = 0;
 
     Impl(
         std::string const& id,
@@ -83,7 +84,14 @@ class ModDownload::Impl final {
             }
 
             if (!ModDownloadManager::get()->checkAutoConfirm()) {
-                ModDownloadEvent(m_id).post();
+                // Throttle events to only once per frame to not cause a 
+                // billion UI updates at once 
+                if (m_scheduledEventForFrame != CCDirector::get()->getTotalFrames()) {
+                    m_scheduledEventForFrame = CCDirector::get()->getTotalFrames();
+                    Loader::get()->queueInMainThread([id = m_id]() {
+                        ModDownloadEvent(id).post();
+                    });
+                }
             }
         });
         auto fetchVersion = version.has_value() ? ModVersion(*version) : ModVersion(ModVersionLatest());
@@ -157,7 +165,14 @@ class ModDownload::Impl final {
             else if (event->isCancelled()) {
                 m_status = DownloadStatusCancelled();
             }
-            ModDownloadEvent(m_id).post();
+            // Throttle events to only once per frame to not cause a 
+            // billion UI updates at once 
+            if (m_scheduledEventForFrame != CCDirector::get()->getTotalFrames()) {
+                m_scheduledEventForFrame = CCDirector::get()->getTotalFrames();
+                Loader::get()->queueInMainThread([id = m_id]() {
+                    ModDownloadEvent(id).post();
+                });
+            }
         });
 
         auto req = web::WebRequest();