Remove unnecessary content type checks

These checks have potentially already been performed in ClassRoutingHandler Closes: quarkusio#37637
geoand · Dec 11, 2023 · f070cb8 · f070cb8
1 parent 8cfaa73
commit f070cb8
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/...src/main/java/org/jboss/resteasy/reactive/server/core/ResteasyReactiveRequestContext.java b/...src/main/java/org/jboss/resteasy/reactive/server/core/ResteasyReactiveRequestContext.java
@@ -796,6 +796,18 @@ public void initPathSegments() {
         }
     }
 
+    private static final String PRODUCES_CHECKED_PROPERTY_KEY = AbstractResteasyReactiveContext.CUSTOM_RR_PROPERTIES_PREFIX
+            + "ProducesChecked";
+
+    public void setProducesChecked(boolean checked) {
+        setProperty(PRODUCES_CHECKED_PROPERTY_KEY, checked);
+    }
+
+    public boolean isProducesChecked() {
+        Object val = getProperty(PRODUCES_CHECKED_PROPERTY_KEY);
+        return val != null && (boolean) val;
+    }
+
     @Override
     public Object getHeader(String name, boolean single) {
         if (httpHeaders == null) {

diff --git a/...untime/src/main/java/org/jboss/resteasy/reactive/server/handlers/ClassRoutingHandler.java b/...untime/src/main/java/org/jboss/resteasy/reactive/server/handlers/ClassRoutingHandler.java
@@ -141,6 +141,8 @@ public void handle(ResteasyReactiveRequestContext requestContext) throws Excepti
                     throw new NotAcceptableException(INVALID_ACCEPT_HEADER_MESSAGE);
                 }
             }
+
+            requestContext.setProducesChecked(true);
         }
 
         requestContext.restart(target.value);

diff --git a/...ntime/src/main/java/org/jboss/resteasy/reactive/server/handlers/FixedProducesHandler.java b/...ntime/src/main/java/org/jboss/resteasy/reactive/server/handlers/FixedProducesHandler.java
@@ -36,7 +36,7 @@ public FixedProducesHandler(MediaType mediaType, EntityWriter writer) {
     @Override
     public void handle(ResteasyReactiveRequestContext requestContext) throws Exception {
         List<String> acceptValues = (List<String>) requestContext.getHeader(HttpHeaders.ACCEPT, false);
-        if (acceptValues.isEmpty()) {
+        if (acceptValues.isEmpty() || requestContext.isProducesChecked()) {
             requestContext.setResponseContentType(mediaType);
             requestContext.setEntityWriter(writer);
         } else {