-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf: Enable cache, fix value casting for MySQL and MariaDB and add plugin for Engine creation #529
Perf: Enable cache, fix value casting for MySQL and MariaDB and add plugin for Engine creation #529
Conversation
To make things simpler we should add a general function like |
3738a90
to
3ec48e5
Compare
3ec48e5
to
0a0450f
Compare
This was made using a plugin for Engine objects. |
See ec72f5f for my proposed changes |
I updated according to your suggestion. I added two parameters, one for MySQL and one for MariaDB, just in case some drivers for MariaDB change their behavior. |
Good idea, looks good to me. |
Great! |
Description
Fixes #436
Cache could not be enabled because of conversion performed in compilation step. Now this conversion is performed during the
before_cursor_execute
event.A SQLAlchemy plugin was created for the
sqlalchemy.Engine
objects in order to automatically attach the relevant events based on the dialect of the Engine.Checklist
This pull request is:
Fixes: #<issue number>
in the description if it solves an existing issue(which must include a complete example of the issue).
main
branch and pass with the provided fix.Fixes: #<issue number>
in the description if it solves an existing issue(which must include a complete example of the feature).