Make session tracking work with API Gateway. #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Gateway always sets the `Geoadmin-Authenticated` and `Geoadmin-Username` headers. When it is not able to authenticate the user, the values are "false" and a single whitespace respectively. The `PersistentRemoteUserMiddleware` class is designed to keep track of users that were authenticated through headers but if the header is set with an invalid value it will log out the user. This change updates our derivation of `PersistentRemoteUserMiddleware` such that it ignores the `Geoadmin-Username` header if `Geoadmin-Authenticated` is not set to "true". A ticket was opened with upstream to make `PersistentRemoteUserMiddleware` more flexible in that regard: https://code.djangoproject.com/ticket/35971 This change also add tests exercising this new behaviour.
This shuts up the linter complaining about the module having too many lines.
Brownser-close-based session expiration overrides age-based expiration. We care more about the age than the browser restart cycle.
benschs
approved these changes
Dec 5, 2024
boecklic
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per commits.
The main change in this PR is to
ApiGatewayMiddlewarewhich is updated to correctly handle the headers that API Gateway sends. In particular in the case where the user is already authenticated via a Django session cookie but where the API GatewayGeoadmin-Usernameheader is invalid.This also refactors and adds tests as well as tweaking session cookie parameters.
This only applies to the debug build. I have verified this works in the dev environment.