Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-1210: Set default file path for assets - #patch #476

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benschs
Copy link
Contributor

@benschs benschs commented Nov 26, 2024

When assets are created via admin GUI there is no file path set. If the file is then uploaded via API using the multipart upload, the file path will never be set on the asset.

This aligns the admin GUI behaviour with that of creating an asset via API PUT.

When assets are created via admin GUI there is no file path set. If the file is
then uploaded via API using the multipart upload, the file path will never be
set on the asset.

This aligns the admin GUI behaviour with that of creating an asset via API PUT.
@benschs benschs requested review from schtibe and hansmannj November 26, 2024 15:45
@github-actions github-actions bot added the bug label Nov 26, 2024
@github-actions github-actions bot changed the title PB-1210: Set default file path for assets PB-1210: Set default file path for assets - #patch Nov 26, 2024
Copy link
Member

@hansmannj hansmannj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean, if an asset is created via admin GUI, but no file is yet uploaded, there will already be a link to a non-existing file?

@benschs benschs marked this pull request as draft November 28, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants