Test the CORS headers for the actual landing page. #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltshb
approved these changes
Aug 8, 2024
adk-swisstopo
force-pushed
the
fix-test-cors
branch
from
ba494ef to
5961c6e
Compare
|
Build failure seems unrelated and caused by PB-694. |
adk-swisstopo
force-pushed
the
fix-test-cors
branch
from
5961c6e to
1e2f088
Compare
This test function assertion was added in 54dca40 It only tests the redirection to the landing page but not the actual landing page. This change ensures the landing page is also covered by this test. It may make sense to test all the pages, which could be done in a separate change.
adk-swisstopo
force-pushed
the
fix-test-cors
branch
from
1e2f088 to
4c08aa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test function assertion was added in 54dca40 It only tests the redirection to the landing page but not the actual landing page.
This change ensures the landing page is also covered by this test.
It may make sense to test all the pages, which could be done in a separate change.