BGDIINF_SB-2704: set Cache-Control Header for temporary 5xx responses

app/__init__.py

@@ -46,6 +46,22 @@ def add_cors_header(response):
     return response
 
 
+# Set Cache Headers
+@app.after_request
+def add_cache_header(response):
+    if request.method not in ('GET', 'HEAD', 'OPTIONS'):
+        return response
+
+    # overwrite with these 5xx cache settings
+    # no cache on these 5xx errors, they are supposed to be temporary
+    if response.status_code in (502, 503, 504, 507):
+        response.headers['Cache-Control'] = 'no-cache'
+    # short cache duration for other 5xx errors
+    elif response.status_code >= 500:
+        response.headers['Cache-Control'] = 'public, max-age=10'
+    return response
+
+
 # Helper method for add_cors_header
 def get_registered_method(url_rule):
     '''Returns the list of registered method for the given endpoint'''

tests/unit_tests/test_checker.py

@@ -18,7 +18,14 @@ def __liveness_test_get_request(self, headers):
     def __readiness_test_get_request(self, headers, expected_status=200):
         response = self.test_instance.get(url_for('readiness'), headers=headers)
         self.check_response(response, expected_status=expected_status)
-        self.assertNotIn('Cache-Control', response.headers)
+        if expected_status < 500:
+            self.assertNotIn('Cache-Control', response.headers)
+        elif expected_status in (502, 503, 504, 507):
+            self.assertIn('Cache-Control', response.headers)
+            self.assertIn('no-cache', response.headers['Cache-Control'])
+        elif expected_status >= 500:
+            self.assertIn('Cache-Control', response.headers)
+            self.assertIn('max-age', response.headers['Cache-Control'])
         self.assertEqual(response.content_type, "application/json")
 
     def test_liveness_intern_origin(self):