Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGDIINF_SB-2479: Now the CORS header accepts every origin. Also updated unit tests. #112

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

jedef
Copy link
Contributor

@jedef jedef commented Jun 29, 2022

Updated the cors header to accept every origin as it is a public api. Also added "Access-Control-Allow-Headers" and updated to unit tests to check for the presence of the CORS headers.

@jedef jedef requested a review from ltshb June 29, 2022 08:58
@github-actions github-actions bot added the bug label Jun 29, 2022
@jedef jedef force-pushed the bugfix-2479-fix-cors-header branch from 32ab3f6 to 1965d7b Compare June 29, 2022 09:12
@jedef jedef changed the title Now the CORS header accepts every origin. Also updated unit tests. BGDIINF_SB-2479: Now the CORS header accepts every origin. Also updated unit tests. Jun 29, 2022
@jedef jedef requested a review from ltshb June 29, 2022 12:09
Copy link
Contributor

@ltshb ltshb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@ltshb ltshb merged commit 71355e7 into develop Jun 29, 2022
@ltshb ltshb deleted the bugfix-2479-fix-cors-header branch June 29, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants