Memory leak and build fixes #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every cap_t needs to be free'd by calling cap_free() which does a NULL pointer test itself so callers don't need to. Signed-off-by: Mathias Krause <minipli@grsecurity.net>
Debian bullseye ships with meson 0.56.2 which is too old to understand replace(). Work around that with split() and string concatenation. Signed-off-by: Mathias Krause <minipli@grsecurity.net>
thesamesam
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of a unit test for
pspaxin 6641785 made the CI discover its memory leaks. Fix them.Also add a commit lowering the minimal meson version required to build. Debian is always a few versions behind :/