Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more friendly aliases #150

Closed
wants to merge 2 commits into from
Closed

Add more friendly aliases #150

wants to merge 2 commits into from

Conversation

mgorny
Copy link
Member

@mgorny mgorny commented Nov 28, 2024

See commits for details. Basically, makes the following possible:

# any non-multilib images, including architectures with no multilib at all
FROM gentoo/stage3:nomultilib
# any image with 64-bit time_t, including 64-bit architectures
FROM gentoo/stage3:t64

@mgorny
Add other architectures to "nomultilib" images
828c29d 
Add architectures other than amd64 to "nomultilib" images, given that
they are "nomultilib" by design.  This makes it possible to use:

    FROM gentoo/stage3:nomultilib

without having to separately covered other architectures that don't
feature multilib at all.
@mgorny
Add generic "t64" and "t64-systemd" aliases
0620e43 
Add generic "t64" and "t64-systemd" aliases that cover all images with
64-bit time_t: both t64 images for 32-bit architectures and the regular
images for 64-bit architectures.  This makes it possible to use:

    FROM gentoo/stage3:t64

to get a system with 64-bit time_t without having to separately cover
individual architectures.
thesamesam
thesamesam approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK but try to get @ajakk to comment or be prepared to handle any comments he has post-merge.

ajakk
ajakk approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@ajakk ajakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, seems reasonable to me unless I'm missing some reason these weren't already there.

@mgorny
Copy link
Member Author

mgorny commented Nov 29, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajakk ajakk ajakk approved these changes

@thesamesam thesamesam thesamesam approved these changes

@akhuettel akhuettel Awaiting requested review from akhuettel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgorny @thesamesam @ajakk