Use HEREDOCS in Dockerfiles #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesamesam
reviewed
Feb 27, 2024
HEREDOC syntax is supported in docker https://docs.docker.com/reference/dockerfile/#here-documents Why: 1) better readability 2) ability to add comments 3) can use HEREDOC in RUN command itself (i.e. configuring ~/.gnupg/dirmngr.conf) 4) by using modern syntax, we can't be labelled as "conservative"[1] [1] systemd/systemd#31424 (comment) Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
HEREDOC syntax is supported in docker https://docs.docker.com/reference/dockerfile/#here-documents Why: 1) better readability 2) ability to add comments 3) can treat it like another bash script Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
HEREDOC syntax is supported in docker https://docs.docker.com/reference/dockerfile/#here-documents Why: 1) better readability 2) ability to add comments 3) can use HEREDOC in RUN command itself (i.e. configuring ~/.gnupg/dirmngr.conf) What else changed: 1) added fallback method to retrieve gpg keys using wkd Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
ajakk
approved these changes
Mar 3, 2024
robbat2
reviewed
Mar 3, 2024
| RUN <<-EOF | ||
| set -e | ||
|
|
||
| apk add --no-cache ca-certificates gnupg tar wget xz |
There was a problem hiding this comment.
busybox-tar & busybox-wget are already present in the image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.