Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PoC disclaimer #15 #16

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Add PoC disclaimer #15 #16

merged 1 commit into from
Apr 16, 2024

Conversation

4TT1L4
Copy link
Contributor

@4TT1L4 4TT1L4 commented Apr 16, 2024

@4TT1L4 4TT1L4 requested a review from MatD9 April 16, 2024 14:18
@4TT1L4
Copy link
Contributor Author

4TT1L4 commented Apr 16, 2024

This PR adds a warning disclaimer on initialization about the state of the example strategy implementations:

image

These example strategies are only intended as implementation references. These are not intended to be used in production

MatD9
MatD9 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@MatD9 MatD9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@4TT1L4 4TT1L4 merged commit 63849db into main Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatD9 MatD9 MatD9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4TT1L4 @MatD9