feat: add support of both v1 & v1.1 family of scripts #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabhxyz
commented
Apr 17, 2024
| @@ -71,10 +65,6 @@ data OrderBotConfig = | |||
| {- ^ The duration (microseconds) of time we wait before re-initiating a | |||
| complete iteration for the bot. | |||
| -} | |||
| , botCFPNftPolicy :: FilePath | |||
There was a problem hiding this comment.
All the boilerplate information is already encoded in geniusyield-dex-api cabal project and so is no longer required.
This change would still be backwards compatible wrt configuration as extra json fields or environment variables would simply be ignored.
sourabhxyz
commented
Apr 17, 2024
| -> [OrderAssetPair] | ||
| -> IO (Map OrderAssetPair [SomeOrderInfo]) | ||
| allOrderInfos c dex assetPairs = do | ||
| cTime <- getCurrentGYTime | ||
|
|
||
| partialOrderInfos <- runQuery c $ | ||
| runReaderT (partialOrders $ partialOrderFilter cTime) dex | ||
| runReaderT (partialOrdersWithTransformerPredicate (dexPORefs dex) $ partialOrderFilter cTime) dex |
There was a problem hiding this comment.
partialOrdersWithTransformerPredicate has type signature,
partialOrdersWithTransformerPredicate
∷ GYDexApiQueryMonad m a
⇒ PORefs
→ (PartialOrderInfo → Maybe b)
→ m [b]whereas partialOrders have type signature,
partialOrders
∷ GYDexApiQueryMonad m a
⇒ PORefs
→ m (Map.Map GYTxOutRef PartialOrderInfo)And definition of partialOrdersWithTransformerPredicate is
partialOrdersWithTransformerPredicate pors transformerPredicate = do
ois ← Map.elems <$> partialOrders pors
pure $ mapMaybe transformerPredicate ois
sourabhxyz
commented
Apr 17, 2024
|
|
||
| source-repository-package | ||
| type: git | ||
| location: https://github.com/geniusyield/dex-contracts-api |
There was a problem hiding this comment.
Using commit from this PR.
Let's merge PR at dex-contracts-api side once our systems are all up to date, since that PR would create orders at v1.1 script.
brunjlar
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100, #78.
To test, I created two orders, one at v1 & other at v1.1. My SOR was able to match them, match tx: link.