fix: remove unnecessary nesting of get order details response #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabhxyz
changed the title
sourabhxyz
commented
May 20, 2024
| @@ -376,8 +376,7 @@ type OrdersAPI = | |||
| :> Description "Get details of an order using it's unique NFT token. Note that each order is identified uniquely by an associated NFT token which can then later be used to retrieve it's details across partial fills." | |||
| :> "details" | |||
| :> Capture "nft-token" GYAssetClass | |||
| :> Throws PodOrderNotFound | |||
| :> Get '[JSON] OrderInfoDetailed | |||
| :> UVerb 'GET '[JSON] '[WithStatus 200 OrderInfoDetailed, WithStatus 404 PodOrderNotFound] | |||
There was a problem hiding this comment.
Have made a move from servant-checked-exceptions to the approach mentioned here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62, #63. See linked issues for more details.
Also adds bot variant of multi fill endpoint.