Skip to content

Do not send cookies in HttpClient if IncludeCookies is false #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Do not send cookies in HttpClient if IncludeCookies is false #816

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91d349d
Do not send cookies in HttpClient if IncludeCookies is false
iroqueta Dec 28, 2023
e5d1351
Merge branch 'master' into IncludeCookieHttpClient
iroqueta Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions java/src/main/java/com/genexus/internet/HttpClientJavaLib.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,11 @@ private static SSLConnectionSocketFactory getSSLSecureInstance() {
private CookieStore setAllStoredCookies() {
CookieStore cookiesToSend = new BasicCookieStore();
if (!ModelContext.getModelContext().isNullHttpContext()) { // Caso de ejecucion de varias instancia de HttpClientJavaLib, por lo que se obtienen cookies desde sesion web del browser

String selfWebCookie = ((HttpContextWeb) ModelContext.getModelContext().getHttpContext()).getCookie(SET_COOKIE);
if (!selfWebCookie.isEmpty())
this.addHeader(COOKIE, selfWebCookie.replace("+",";"));

if (getIncludeCookies()) {
String selfWebCookie = ((HttpContextWeb) ModelContext.getModelContext().getHttpContext()).getCookie(SET_COOKIE);
if (!selfWebCookie.isEmpty())
this.addHeader(COOKIE, selfWebCookie.replace("+", ";"));
}
} else { // Caso se ejecucion de una misma instancia HttpClientJavaLib mediante command line
if (!getIncludeCookies())
cookies.clear();
Expand Down