- Add Access token property and processing in Location object #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry pick to beta success |
iroqueta
reviewed
Sep 20, 2023
| @@ -506,6 +506,9 @@ public void RestExecute() { | |||
| httpClient.addHeader("Content-Type", contentType); | |||
| } | |||
| } | |||
| if (this.location.getAuthenticationMethod() == 4 && this.location.getAccessToken() != null && ! this.location.getAccessToken().trim().isEmpty()) { | |||
There was a problem hiding this comment.
Why do you use this.location instead of only location?
The same with this.httpMethod
There was a problem hiding this comment.
Right, It's unnecessary, Removed.
- Fix test case when receiving unwrapped response.
Cherry pick to beta success |
Cherry pick to beta success |
iroqueta
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AccessToken property to location object to access GAM protected services.