Skip to content

Add opentelemetry spans #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 21, 2023
Merged

Add opentelemetry spans #766

merged 4 commits into from
Sep 21, 2023

Conversation

sjuarezgx
Copy link
Contributor

@genexusbot
Copy link
Collaborator

Cherry pick to beta failed, 1 conflicted file in commit 70ec824
  • pom.xml

@genexusbot
Copy link
Collaborator

Manual cherry pick to beta success

@sjuarezgx sjuarezgx requested a review from iroqueta August 21, 2023 12:16
iroqueta
iroqueta reviewed Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@iroqueta iroqueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you create another var to set opentelemetry version?
I think that it would be better use the one that allready exist (io.opentelemetry.version) and change it.

@genexusbot
Copy link
Collaborator

Cherry pick to beta failed, 1 conflicted file in commit 2c1484e
  • pom.xml

@genexusbot
Copy link
Collaborator

Manual cherry pick to beta success

@sjuarezgx sjuarezgx merged commit a34f413 into master Sep 21, 2023
@sjuarezgx sjuarezgx deleted the OpentelemetrySpans branch September 21, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iroqueta iroqueta iroqueta approved these changes

Assignees
No one assigned
Labels
bot closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sjuarezgx @genexusbot @iroqueta @cinthamo