Initial PDFBox HTML support #748
Conversation
Issue: 102725
Alerts 236, 235, 234, 233, 231, 230, 229, 228, 227 and 226
…tify Issue: 102800
Fixes 225, 224, 223, 221, 220, 219, 218, 217, 216, 215, 214 and 213
tomas-sexenian
force-pushed
the
PDFBoxHTMLSupport
branch
from
2250387 to
00fb416
Compare
| @@ -122,6 +122,11 @@ | |||
| <version>2.0.27</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.jsoup</groupId> | |||
| <artifactId>jsoup</artifactId> | |||
There was a problem hiding this comment.
@tomas-sexenian as we added a new required dependency, do you know how mucho size this JAR takes?
There was a problem hiding this comment.
Jsoup 1.16 takes 433 KB of space which I agree is not optimal. Advantages are that it is open source, free for comercial use, has no known vulnerabilities and its complete enough to handle more complex HTML structures if, in the future, we wanted to expand HTML rendering for PDFBox generated reports.
I can try rewriting what I have now but using another HTML parsing library if it is necessary
|
In the future, I think we should consider to refactor all PDF implementation into a new Module. |
|
I agree that we should do something with all the files involved in PDF generation. Modules are a great option but we could also evaluate if, for example, the report being generated is rendering HTML content and if its not, then Jsoup its not necessary. Same goes to barcodes and QR codes rendering |
Cherry pick to beta success |
Issue: 103392