Cherry pick branch 'genexuslabs:storage-unittest-localstack' into beta

genexuslabs · Jan 8, 2025 · 574a87f · 574a87f
1 parent 888a49b
commit 574a87f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.github/workflows/External-Storage-Tests.yml b/.github/workflows/External-Storage-Tests.yml
@@ -76,6 +76,7 @@ jobs:
         STORAGE_AWSS3_FOLDER_NAME: "gxclasses"
         STORAGE_AWSS3_REGION: "us-east-1"
         STORAGE_AWSS3_ENDPOINT: "custom"
+        S3_SKIP_URL_SIGNATURE_TEST: "true"
         STORAGE_AWSS3_CUSTOM_ENDPOINT: "http://localhost:4566"
         IBMCOS_TEST_ENABLED: "true"
         STORAGE_IBMCOS_ACCESS_KEY: "${{ secrets.IBMCOS_ACCESS_KEY }}"

diff --git a/dotnet/test/DotNetUnitTest/ExternalProvider/ExternalProviderTest.cs b/dotnet/test/DotNetUnitTest/ExternalProvider/ExternalProviderTest.cs
@@ -393,8 +393,15 @@ private static void Wait(int milliseconds)
 		private void EnsureUrl(String signedOrUnsignedUrl, GxFileType acl)
 		{
 			Assert.True(UrlExists(signedOrUnsignedUrl), "URL not found: " + signedOrUnsignedUrl);
-			if (IsPrivateFile(acl))
+
+			bool skipUrlSignatureTests = !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("S3_SKIP_URL_SIGNATURE_TEST"));
+			if (skipUrlSignatureTests)
 			{
+				return;
+			}
+
+			if (IsPrivateFile(acl))
+			{				
 				if (!(this is ExternalProviderMinioTest)) //Minio local installation not supported
 				{
 					Skip.If(this is ExternalProviderMinioTest);