Move data.table from Depends to Imports #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thank you for using {data.table} in your package!
{data.table} is currently in your
Depends, which we strongly discouraged; see the vignette on importing data.table: https://cran.r-project.org/web/packages/data.table/vignettes/datatable-importing.html.This PR attempts to make the migration from Depends to Imports for data.table. It also
Importsbut I don't know those packages at all to be able to weigh the risks.usethis::use_package_doc(), given that the documentation is managed by {roxygen2}.If you have a strong reason for preferring Depends, we'd love to hear it over at our issue tracker:
Rdatatable/data.table#3076