fix: Show permalink editor in editor (WordPress#7494)

* fix: Show permalink editor in editor (fix WordPress#7467) * Use getCurrentPost() to get the link
generoi · Jun 26, 2018 · 04c0ea2 · 04c0ea2
1 parent a56c54d
commit 04c0ea2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 37 deletions.
diff --git a/editor/components/post-permalink/index.js b/editor/components/post-permalink/index.js
@@ -56,11 +56,11 @@ class PostPermalink extends Component {
 	}
 
 	render() {
-		const { isNew, previewLink, isEditable, samplePermalink, isPublished } = this.props;
+		const { isNew, postLink, isEditable, samplePermalink, isPublished } = this.props;
 		const { isCopied, isEditingPermalink } = this.state;
 		const ariaLabel = isCopied ? __( 'Permalink copied' ) : __( 'Copy the permalink' );
 
-		if ( isNew || ! previewLink ) {
+		if ( isNew || ! postLink ) {
 			return null;
 		}
 
@@ -80,7 +80,7 @@ class PostPermalink extends Component {
 				{ ! isEditingPermalink &&
 					<Button
 						className="editor-post-permalink__link"
-						href={ ! isPublished ? previewLink : samplePermalink }
+						href={ ! isPublished ? postLink : samplePermalink }
 						target="_blank"
 						ref={ ( permalinkButton ) => this.permalinkButton = permalinkButton }
 					>
@@ -123,10 +123,19 @@ class PostPermalink extends Component {
 
 export default compose( [
 	withSelect( ( select ) => {
-		const { isEditedPostNew, isPermalinkEditable, getEditedPostPreviewLink, getPermalink, isCurrentPostPublished } = select( 'core/editor' );
+		const {
+			isEditedPostNew,
+			isPermalinkEditable,
+			getCurrentPost,
+			getPermalink,
+			isCurrentPostPublished,
+		} = select( 'core/editor' );
+
+		const { link } = getCurrentPost();
+
 		return {
 			isNew: isEditedPostNew(),
-			previewLink: getEditedPostPreviewLink(),
+			postLink: link,
 			isEditable: isPermalinkEditable(),
 			samplePermalink: getPermalink(),
 			isPublished: isCurrentPostPublished(),

diff --git a/editor/store/selectors.js b/editor/store/selectors.js
@@ -444,17 +444,6 @@ export function getDocumentTitle( state ) {
 	return title;
 }
 
-/**
- * Returns a URL to preview the post being edited.
- *
- * @param {Object} state Global application state.
- *
- * @return {string} Preview URL.
- */
-export function getEditedPostPreviewLink( state ) {
-	return getCurrentPost( state ).preview_link || null;
-}
-
 /**
  * Returns a new reference when the inner blocks of a given block UID change.
  * This is used exclusively as a memoized selector dependant, relying on this

diff --git a/editor/store/test/selectors.js b/editor/store/test/selectors.js
@@ -39,7 +39,6 @@ const {
 	hasAutosave,
 	isEditedPostEmpty,
 	isEditedPostBeingScheduled,
-	getEditedPostPreviewLink,
 	getBlockDependantsCacheBust,
 	getBlockName,
 	getBlock,
@@ -1314,26 +1313,6 @@ describe( 'selectors', () => {
 		} );
 	} );
 
-	describe( 'getEditedPostPreviewLink', () => {
-		it( 'should return null if the post has not link yet', () => {
-			const state = {
-				currentPost: {},
-			};
-
-			expect( getEditedPostPreviewLink( state ) ).toBeNull();
-		} );
-
-		it( 'should return the correct url when the post object has a preview_link', () => {
-			const state = {
-				currentPost: {
-					preview_link: 'https://andalouses.com/?p=1&preview=true',
-				},
-			};
-
-			expect( getEditedPostPreviewLink( state ) ).toBe( 'https://andalouses.com/?p=1&preview=true' );
-		} );
-	} );
-
 	describe( 'getBlockDependantsCacheBust', () => {
 		const rootBlock = { uid: 123, name: 'core/paragraph', attributes: {} };
 		const rootOrder = [ 123 ];