Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Gene_EncryptionKeyManager: Add support for JSON fields #27

Merged

Conversation

tedsalmon
Copy link
Contributor

  • Add ability to re-encrypt columns with JSON blobs in them using dot notation.
  • Update docs

* Add ability to re-encrypt columns with JSON blobs in them using dot notation.
* Update docs
@convenient
Copy link
Contributor

Hello @tedsalmon

Well this is something I didn't anticipate. Am I correct in remembering that column names in mysql are not allowed to have a . in them? That means this should be safe?

So that I can capture a test case could you please provide me an example JSON payload? The tests for this module are very rough and ready so I'm happy to craft that myself if you can get me started

@tedsalmon
Copy link
Contributor Author

Hi @convenient !

Well this is something I didn't anticipate. Am I correct in remembering that column names in mysql are not allowed to have a . in them? That means this should be safe?

Yeah, dots are a SQL delimiter character, thus they are not valid in schema, table or column names.

So that I can capture a test case could you please provide me an example JSON payload? The tests for this module are very rough and ready so I'm happy to craft that myself if you can get me started

Here you go:

 {
     "behavior": "append",
     "import_source": "file",
     "user": "",
     "password": "0:3:RV6\/qFFHn1zU2QmpFA9cysL5fdxS17T34LeY0jwx27u\/SiTtgVmOzw==",
     "username": "0:3:r+6nYk642juvyu7+YGUl0mNmA3qbApenyl\/STX7XTh7\/SHNYzA==",
     "soap_version": "SOAP_1_1",
     "request_url": "",
 }

Thanks!
-Ted

convenient added a commit that referenced this pull request Jul 24, 2024
[IMP] Gene_EncryptionKeyManager: Add support for JSON fields (#27 plus test)
@convenient convenient merged commit ddfb0f7 into genecommerce:master Jul 24, 2024
@convenient
Copy link
Contributor

Thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants