Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --skip-saved-credit-cards to generate #26

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Add --skip-saved-credit-cards to generate #26

merged 1 commit into from
Jul 22, 2024

Conversation

convenient
Copy link
Contributor

From @braders in #9 (comment)

I am working on a site with around 2.5 million records in the sales_order_payment table, and am wary to try loading that into memory.

We don't support saved card numbers, and so cc_number_enc is always empty. It'd be nice to have the possibility to skip running the _reEncryptCreditCardNumbers function.

@convenient convenient mentioned this pull request Jul 22, 2024
Open
@braders
Copy link

braders commented Jul 22, 2024

Amazingly quick work. Looks good to me.

@convenient convenient merged commit b2c26d1 into master Jul 22, 2024
1 check passed
@convenient convenient deleted the add-skip-saved-credit-cards-to-generate branch July 22, 2024 17:21
@convenient
Copy link
Contributor Author

Thats tagged now @braders https://github.com/genecommerce/module-encryption-key-manager/releases/tag/v0.0.9-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnewbs cjnewbs cjnewbs approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@convenient @braders @cjnewbs