Disable sonarscan for dependabot #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot PRs don't have access to build secrets, such as the token we need to use to authenticate with sonarcloud. The current dependabot workflow requires us to manually check each PR to ensure only the sonarcloud step failed (and that stuff like tests are fine) which causes friction and toil. This change will allow us to even go as far as automerging dependabot, should we want to- our dependabot PRs will actually become useful and friction-free
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot PRs don't have access to build secrets, such as the token we need to use to authenticate with sonarcloud.
The current dependabot workflow requires us to manually check each PR to ensure only the sonarcloud step failed (and that stuff like tests are fine) which causes friction and toil.
This change will allow us to even go as far as automerging dependabot, should we want to- our dependabot PRs will actually become useful and friction-free