Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI refactoring #288

Merged
merged 3 commits into from
Oct 4, 2021
Merged

CI refactoring #288

merged 3 commits into from
Oct 4, 2021

Conversation

cw789
Copy link
Contributor

@cw789 cw789 commented Sep 30, 2021

Refactoring CI to not be in need to ship the rebar3 binary within the repository itself.
Additionally it newly includes caching.
The tests now run on every push and pull (for now?).
OTP 21 uses rebar3 3.15.2, newer OTP the currently latest rebar3 3.17.0.

Matrix:
I would build EDoc only on latest OTP. I don't get the benefit of building it on various versions (but you could proof me wrong).
We could expand tests to run on more OTP / rebar3 combinations? I don't know if needed.

@cw789 cw789 marked this pull request as ready for review October 1, 2021 08:06
@cw789
Copy link
Contributor Author

cw789 commented Oct 1, 2021

Ready for review or discussions now.

Copy link
Collaborator

@seriyps seriyps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@cw789
Copy link
Contributor Author

cw789 commented Oct 3, 2021

I did some wrong merge things will tidy up the commits later.

Copy link
Collaborator

@seriyps seriyps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@seriyps seriyps requested a review from mworrell October 4, 2021 07:23
@mworrell mworrell merged commit fb7f896 into gen-smtp:master Oct 4, 2021
@cw789 cw789 deleted the ci_refactoring branch October 4, 2021 09:40
@cw789
Copy link
Contributor Author

cw789 commented Oct 4, 2021

Thanks for merging. Doc seems to not run on master (default branch) but should do so.
I'll check that and send an additional PR.

Edit: #289

@mworrell
Copy link
Collaborator

mworrell commented Oct 4, 2021

Ah, missed that part reviewing the changes.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants