fix: use temp path to save diff image #548
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi thx for your PR. can you, pls, provide an example to reproduce this bug? |
shtyr-maxim
force-pushed
the
fix-diff-images-saving
branch
from
8350e01
to
b77dcf2
Compare
|
Hi! I've created a minimal environment to demonstrate this issue. You can find it here: html-reporter-bug.zip. After running the |
shadowusr
force-pushed
the
fix-diff-images-saving
branch
from
412d940
to
fb6b628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the error of storing diff images in the project's working directory.
Expected behavior
The difference image is saved in
$TMPDIR/...path before copying toreportPathActual behavior
The difference image is saved in
$PWD/images/...before copying toreportPath