Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading GMFs #733

Merged
merged 3 commits into from
Apr 27, 2020
Merged

Fix loading GMFs #733

merged 3 commits into from
Apr 27, 2020

Conversation

ptormene
Copy link
Member

@ptormene ptormene commented Apr 21, 2020

While making a recent change I did not notice I was modifying a dict while looping on its keys, which caused the loop to make an undesired additional iteration. As a consequence, an empty field with a strange name was added to the layer.

Fixes #730
Fixes #728

@ptormene ptormene added the bug label Apr 21, 2020
@ptormene ptormene self-assigned this Apr 21, 2020
@ptormene ptormene added WIP and removed WIP labels Apr 21, 2020
Copy link
Collaborator

@CatalinaYepes CatalinaYepes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CatalinaYepes
Copy link
Collaborator

An additional issue is appearing when loading the gmfs for scenarios.

Independently from the selected event_id, always the rlz-0 name is displayed.

For example the picture below show the results for a calculation with a total of 60 events with 3 GMPEs (20 events per GMPE), but the name is the same in all cases.

Screen Shot 2020-04-24 at 5 06 00 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken attribute table for gmfs with multiples GMPEs and multiple IMTs Broken color ramp for gmfs plots
2 participants