This repository was archived by the owner on Apr 16, 2024. It is now read-only.
Fix apidoc syntax #738
Merged
Fix apidoc syntax #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
.travis.yml
Outdated
| @@ -72,6 +72,7 @@ script: | |||
| - cd api | |||
| - sed -i 's/$TRAVIS_COMMIT/'$TRAVIS_COMMIT'/' src/server.ts | |||
| - npm run test # run backend test | |||
| - npm run apidoc # generate apidoc | |||
There was a problem hiding this comment.
This is a bad idea, I wrote a better script for it!
…into bugfix/737-fix-apidoc
|
@danielkesselberg what do you think about the script? |
|
@PatrickSkowronek looks fine. I added chmod +x and remove fi before elif/else. We may change the name to keep up with the other scripts (- instead of _). I would try to merge if/elif block like below but this only works for bash and is not portable:
|
…into bugfix/737-fix-apidoc
|
Looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closes #737
Improvements