Skip to content
This repository was archived by the owner on Apr 16, 2024. It is now read-only.

Feature/#598 course detail #666

Merged
merged 15 commits into from
May 2, 2018
Merged

Feature/#598 course detail #666

merged 15 commits into from
May 2, 2018

Conversation

wurmc
Copy link
Collaborator

@wurmc wurmc commented Apr 22, 2018 •
edited by a-siewe
Loading

Description:

  • Teachers of a course shown in a chip list
  • Clicking on a teacher shows his profile in a dialog.

Closes #598

Improvements

  • teacher details now shown in course

Known Issues:

Remember to prefix your PR-Title with ⚠ WIP: if you still work on it.
If you have reached a final state, remove the prefix.

wurmc added 2 commits April 22, 2018 16:40
@wurmc
feature: added details view of theacher to course detail view. dummie…
6cdbf5b 
… picture at the moment. further functions and updates to be added.
@wurmc
feature: added details of teacher to course detail view. dummie pictu…
5ee2fe3 
…re at the moment. further functions and updates to be added.
@PatrickSkowronek
Copy link
Collaborator

@wurmc you comited the package-lock.json an package.json, which is bad. You should revert these files!

@coveralls
Copy link

coveralls commented Apr 22, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 64.232% when pulling 2ee4047 on feature/#598_course_detail into b9a0769 on develop.

@a-siewe a-siewe changed the title ⚠ WIP: Feature/#598 course detail Feature/#598 course detail Apr 26, 2018
@PatrickSkowronek PatrickSkowronek added the blocked This Issue is blocked or can't be solved yet label Apr 29, 2018
@PatrickSkowronek
Copy link
Collaborator

This is blocked, because the user is not set in the course. This will be resolved after #691 !

torss added a commit that referenced this pull request May 2, 2018
@torss
Shared: Add new IUserSubCourseView interface
d67aba3 
This is relevant for PR #666 i.e. issue #598.
torss added a commit that referenced this pull request May 2, 2018
@torss
Utilize IUserSubCourseView in ICourseView
de23779 
This is relevant for PR #666 i.e. issue #598.
It gives access to the ID, name, profile picture (as in IUserSubSafe)
and email address (added in IUserSubCourseView) for all course teachers
as well as the courseAdmin via ICourseView.
The corresponding API unit test was adjusted accordingly.
@torss torss mentioned this pull request May 2, 2018
Merged
@PatrickSkowronek PatrickSkowronek removed the blocked This Issue is blocked or can't be solved yet label May 2, 2018
PatrickSkowronek
PatrickSkowronek approved these changes May 2, 2018
View reviewed changes
Copy link
Collaborator

@PatrickSkowronek PatrickSkowronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work

@PatrickSkowronek PatrickSkowronek merged commit 8ef7491 into develop May 2, 2018
@PatrickSkowronek PatrickSkowronek deleted the feature/#598_course_detail branch May 2, 2018 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PatrickSkowronek PatrickSkowronek PatrickSkowronek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add description box to course detail view
5 participants
@wurmc @PatrickSkowronek @coveralls @a-siewe @Armel22